Re: [PATCH v2] I2C: busses: i2c-eg20t Do not print error message insyslog if no ACK received

From: Wolfram Sang
Date: Sun Nov 17 2013 - 07:18:43 EST



> Is there another reason why pch_i2c_getack returned EPROTO?
> May be ENXIO was introduced later?

Imperfect review :)

> I think we can just replace the -EIO with -ENXIO or do you want to pick up the return
> vale of pch_i2c_getack and return that ?

The latter. As a rule of thumb, it is usually more sustainable to pass
through error codes. Overloading them should only be done when really
necessary IMO.

Attachment: signature.asc
Description: Digital signature