Re: [PATCH 00/10] leds: lp5521,5523: restore device attributes forrunning LED patterns

[Milo Kim]

Hi Bryan,

On 11/20/2013 04:20 AM, Bryan Wu wrote:
> On Tue, Nov 19, 2013 at 2:35 AM, Pali Rohár<pali.rohar@xxxxxxxxx>  wrote:
> > >Hello,
> > >
> > >now I tested that patch on top of 3.12-rc5 with this led example:
> > >
> > >     # Clearing LED-state to be sure
> > >     echo "disabled" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode
> > >     echo "disabled" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode
> > >     echo 0 > /sys/class/leds/lp5523:r/brightness
> > >     echo 0 > /sys/class/leds/lp5523:g/brightness
> > >     echo 0 > /sys/class/leds/lp5523:b/brightness
> > >
> > >     # Setting yellow light pattern and running it
> > >     echo "load" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode
> > >     echo "000001100" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_leds
> > >     echo "9d804000427f0d7f7f007f0042000000" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_load
> > >     echo "load" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode
> > >     echo "000000000" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_leds
> > >     echo "9d800000" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_load
> > >     echo "run" > /sys/class/i2c-adapter/i2c-2/2-0032/engine2_mode
> > >     echo "run" > /sys/class/i2c-adapter/i2c-2/2-0032/engine1_mode
> > >     echo 20 > /sys/class/leds/lp5523:r/led_current
> > >     echo 2 > /sys/class/leds/lp5523:g/led_current
> > >     echo 0 > /sys/class/leds/lp5523:b/led_current
> > >
> > >And now it working, led blinks :-) I also tested Maemo
> > >application for managing lp5523 led and now it working too.
> > >
> That's good. We can post this fixing patch to stable tree as well as
> latest upstream kernel.
>
> Milo, do you need to update your patch, if not I'm going to take it
> into my tree and for stable tree.

I'll send the patch-set again because LP5521 is also required to be fixed.
And _remove() also needs to be updated.
I can send it by tomorrow.

Thanks,
- Milo


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/