Re: [PATCH] blkcg: have bh disable for 32bit UP system reading 64bitstats

From: Tejun Heo
Date: Wed Nov 20 2013 - 12:24:23 EST


On Wed, Nov 06, 2013 at 07:14:44PM +0800, Hong Zhiguo wrote:
> From: Hong Zhiguo <zhiguohong@xxxxxxxxxxx>
>
> Update of blkg_stat and blkg_rwstat may happen in bh context.
> While u64_stats_fetch_retry is only preempt_disable on 32bit
> UP system. This is not enough to avoid preemption by bh and
> may read strange 64 bit value.
>
> Signed-off-by: Hong Zhiguo <zhiguohong@xxxxxxxxxxx>

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

Jens, can you please pick this one up? This probably needs to be
tagged for stable too.

Thanks!

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/