Re: [RFC PATCH v2 1/5] locks: consolidate checks for compatiblefilp->f_mode values in setlk handlers

From: Christoph Hellwig
Date: Thu Nov 21 2013 - 12:35:40 EST


On Wed, Nov 20, 2013 at 11:45:02AM -0500, Jeff Layton wrote:
> Add a wrapper around assign_type that does this instead of duplicating
> this check in two places. This also fixes a minor wart in the code where
> we continue referring to the struct flock after converting it to struct
> file_lock.

I don't think posix_assign_type is a good name for this helper, but
as Bruce already pointed out more work is required in that area anyway.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/