Re: [PATCH v3 4/5] regulator: max14577: Add regulator driver forMaxim 14577

From: Lee Jones
Date: Fri Nov 22 2013 - 04:17:00 EST


On Fri, 22 Nov 2013, Krzysztof Kozlowski wrote:

> MAX14577 chip is a multi-function device which includes MUIC,
> charger and voltage regulator. The driver is located in drivers/mfd.
>
> This patch adds regulator driver for MAX14577 chip. There are two
> regulators in this chip:
> 1. Safeout LDO with constant voltage output of 4.9V. It can be only
> enabled or disabled.
> 2. Current regulator for the charger. It provides current from 90mA up
> to 950mA.
> Driver supports Device Tree.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
> drivers/regulator/Kconfig | 7 ++
> drivers/regulator/Makefile | 1 +
> drivers/regulator/max14577.c | 272 ++++++++++++++++++++++++++++++++++++++++++
> include/linux/mfd/max14577.h | 1 -
> 4 files changed, 280 insertions(+), 1 deletion(-)
> create mode 100644 drivers/regulator/max14577.c

<snip>

> --- a/include/linux/mfd/max14577.h
> +++ b/include/linux/mfd/max14577.h
> @@ -63,7 +63,6 @@ struct max14577_platform_data {
>
> int (*set_gpio_pogo_cb) (int new_dev);
>
> - int num_regulators;

This doesn't belong in this patch.

> struct max14577_regulator_platform_data *regulators;
> };
>

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/