Re: [BUG] 3ce1217d6cd5 ima patch causes s390 to crash on boot

From: Mimi Zohar
Date: Fri Nov 22 2013 - 11:40:32 EST


On Fri, 2013-11-22 at 17:35 +0100, Heiko Carstens wrote:
> On Fri, Nov 22, 2013 at 05:23:49PM +0100, Roberto Sassu wrote:
> > Another problem that I found is that strsep()
> > modifies the source buffer by replacing the separator
> > character with '\0'. In particular, this function
> > modifies static data initialized at the beginning
> > of the ima_template.c file. Maybe, this is causing
> > the kernel panic. I already sent a patch to fix this
> > problem (attached to the email) even if it is not
> > supposed to land on the 3.13 kernel. Let me know
> > if this fixes the issue. Otherwise, I will check
> > the code more in depth.
>
> With your patch below applied the kernel boots again.
> So it should go into 3.13 (or a different fix).
>
> Thanks!

Thanks for testing! There are a number of bug fixes for this release in
linux-integrity/ima-fixes-new. Now that the security patches made it
into Linus' tree, I'll send the pull request to James.

thanks,

Mimi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/