Re: [PATCH v2 3/7] net: rfkill: gpio: remove gpio conversion support

From: Heikki Krogerus
Date: Fri Nov 22 2013 - 15:57:34 EST


On Fri, Nov 22, 2013 at 11:40:32AM -0700, Stephen Warren wrote:
> On 11/22/2013 05:14 AM, Mika Westerberg wrote:
> > From: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> >
> > All platforms using this driver are now converted to the new
> > descriptor-based GPIO interface.
>
> Don't you want to remove the fields from the pdata structure too, since
> it's pointless to set them anymore IIUC?

Agreed. We should have removed them in this patch.

I have prepared a separate patch where I remove those and some other
unused fields from the pdata structure (attachment). Would it be OK to
add that to this patch set? Or should this patch simply be updated?

--
heikki