Re: [PATCH 1/5] futex: Misc cleanups

From: Darren Hart
Date: Sat Nov 23 2013 - 01:53:12 EST


On Fri, 2013-11-22 at 16:56 -0800, Davidlohr Bueso wrote:
> From: Jason Low <jason.low2@xxxxxx>
>
> - Remove unnecessary head variables.
> - Delete unused parameter in queue_unlock().
>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Darren Hart <dvhart@xxxxxxxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Mike Galbraith <efault@xxxxxx>
> Cc: Jeff Mahoney <jeffm@xxxxxxxx>
> Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Cc: Scott Norton <scott.norton@xxxxxx>
> Cc: Tom Vaden <tom.vaden@xxxxxx>
> Cc: Aswin Chandramouleeswaran <aswin@xxxxxx>
> Cc: Waiman Long <Waiman.Long@xxxxxx>
> Signed-off-by: Jason Low <jason.low2@xxxxxx>
> Signed-off-by: Davidlohr Bueso <davidlohr@xxxxxx>

My concern was that we saved off head for a reason, but the hb lock is
held in these cases, and the call is safe against removal, so I don't
see a problem. Thanks.

Reviewed-by: Darren Hart <dvhart@xxxxxxxxxxxxxxx>

--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/