Re: [PATCH] CMA: Fix the phys_addr_t print types

From: Greg Kroah-Hartman
Date: Sat Nov 23 2013 - 22:43:52 EST


On Sat, Nov 23, 2013 at 10:37:01PM -0500, Santosh Shilimkar wrote:
> @@ -250,8 +249,8 @@ int __init dma_contiguous_reserve_area(phys_addr_t size, phys_addr_t base,
> *res_cma = cma;
> cma_area_count++;
>
> - pr_info("CMA: reserved %ld MiB at %08lx\n", (unsigned long)size / SZ_1M,
> - (unsigned long)base);
> + pr_info("CMA: reserved %ld MiB at %pa\n", (unsigned long)size / SZ_1M,
> + &base);

Why is this pr_info() at all? That's just noise, please move it to
pr_debug().

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/