Re: [PATCH] Cpufreq: Change sysfs interface cpuinfo_cur_freq access privilege

From: Rafael J. Wysocki
Date: Mon Nov 25 2013 - 06:14:11 EST


On Monday, November 25, 2013 01:33:39 PM Lan Tianyu wrote:
> On 2013å11æ25æ 12:30, Viresh Kumar wrote:
> > On 25 November 2013 08:23, Lan Tianyu <tianyu.lan@xxxxxxxxx> wrote:
> >> Currently, cpuinfo_cur_freq is only accessible for root user while
> >> other cpufreq sysfs interfaces(E,G scaling_cur_freq) are available
> >> to ordinary user. This seems make no sense. This patch is to change
> >> it.
> >
> > There is nothing wrong with the code and so this is more of a design
> > change..
> >
> > Probably Rafael can help us here as cpufreq_cur_freq will read stuff
> > directly from hardware instead of using cached value in software.
>
> I think so, too. I also tried to checking the reason of the privilege by
> git log but the code was there before linux kernel being migrated to git
> repository.

And it has always behaved in the same way? Then I wouldn't change it.

Thanks!

--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/