Re: [GIT PULL] ima: bug fixes for Linus

[Roberto Sassu]

On 11/25/2013 04:40 PM, James Morris wrote:
> On Mon, 25 Nov 2013, Mimi Zohar wrote:
>
> > Hi James,
> >
> > These are the "essential fixes for regressions".
> >
> > The following changes since commit 4c1cc40a2d49500d84038ff751bc6cd183e729b5:
> >
> >    Revert "KEYS: verify a certificate is signed by a 'trusted' key" (2013-11-23 16:38:17 -0800)
> >
> > are available in the git repository at:
> >
> >    git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity for-linus
> >
> > for you to fetch changes up to 72ca1bd303a5126d0ce377cff699282b6b38bd86:
> >
> >    ima: make a copy of template_fmt in template_desc_init_fields() (2013-11-25 07:32:46 -0500)
> >
> > thanks,
> >
> > Mimi
> >
> > ----------------------------------------------------------------
> > Roberto Sassu (3):
>
> >        ima: make a copy of template_fmt in template_desc_init_fields()
>
>
> > template_desc_init_fields(char *template_fmt,
>
> That should probably be const char.
>
> Also, the call to kstrdup() results in a memory leak.

Hi James

thanks for the comments. I'm implementing them and I will post
a new version of the patch 'ima: make a copy of template_fmt in
template_desc_init_fields()' shortly.

Roberto Sassu


>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/