RE: [PATCH] crypto/caam/jr.c: include linux/of_address.h

From: Ruchika Gupta
Date: Tue Nov 26 2013 - 04:44:36 EST


A Patch for this has already been submitted.

Regards,
Ruchika

> -----Original Message-----
> From: linux-crypto-owner@xxxxxxxxxxxxxxx [mailto:linux-crypto-
> owner@xxxxxxxxxxxxxxx] On Behalf Of shh.xie@xxxxxxxxx
> Sent: Tuesday, November 26, 2013 12:00 PM
> To: linux-crypto@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Cc: herbert@xxxxxxxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; Xie Shaohui-B21989
> Subject: [PATCH] crypto/caam/jr.c: include linux/of_address.h
>
> From: Shaohui Xie <Shaohui.Xie@xxxxxxxxxxxxx>
>
> to avoid a compile error:
>
> drivers/crypto/caam/jr.c: In function 'caam_jr_probe':
> drivers/crypto/caam/jr.c:468:2: error: implicit declaration of function
> 'of_iomap' [-Werror=implicit-function-declaration]
> drivers/crypto/caam/jr.c:468:7: warning: assignment makes pointer from
> integer without a cast [enabled by default]
>
> Signed-off-by: Shaohui Xie <Shaohui.Xie@xxxxxxxxxxxxx>
> ---
> drivers/crypto/caam/jr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c index
> d23356d2..1d80bd3 100644
> --- a/drivers/crypto/caam/jr.c
> +++ b/drivers/crypto/caam/jr.c
> @@ -6,6 +6,7 @@
> */
>
> #include <linux/of_irq.h>
> +#include <linux/of_address.h>
>
> #include "compat.h"
> #include "regs.h"
> --
> 1.8.4.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--- Begin Message --- Acked-by: Ruchika Gupta <ruchika.gupta@xxxxxxxxxxxxx>

> -----Original Message-----
> From: linux-crypto-owner@xxxxxxxxxxxxxxx [mailto:linux-crypto-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Michael Neuling
> Sent: Monday, November 18, 2013 9:50 AM
> To: Gupta Ruchika-R66431
> Cc: Garg Vakul-B16394; Herbert Xu; linux-crypto@xxxxxxxxxxxxxxx;
> sfr@xxxxxxxxxxxxxxxx
> Subject: [PATCH] crypto: caam - Add missing Job Ring include
>
> linuxnext currently doesn't compile with the powerpc mpc85xx_defconfig
> giving:
>
> drivers/crypto/caam/jr.c: In function 'caam_jr_probe':
> drivers/crypto/caam/jr.c:468:2: error: implicit declaration of function
> 'of_iomap' [-Werror=implicit-function-declaration]
>
> In:
> commit 313ea293e9c4d1eabcaddd2c0800f083b03c2a2e
> Author: Ruchika Gupta <ruchika.gupta@xxxxxxxxxxxxx>
> crypto: caam - Add Platform driver for Job Ring
>
> We added a reference to of_iomap but did add the necessary include file.
>
> The below adds this include.
>
> Signed-off-by: Michael Neuling <mikey@xxxxxxxxxxx>
>
> diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c index
> d23356d2..1d80bd3 100644
> --- a/drivers/crypto/caam/jr.c
> +++ b/drivers/crypto/caam/jr.c
> @@ -6,6 +6,7 @@
> */
>
> #include <linux/of_irq.h>
> +#include <linux/of_address.h>
>
> #include "compat.h"
> #include "regs.h"
> --
> To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at
> http://vger.kernel.org/majordomo-info.html


--- End Message ---