Re: [PATCH v2 03/10] PCI: Move resources and bus_list releasing to pci_release_dev

From: Yinghai Lu
Date: Tue Nov 26 2013 - 21:15:38 EST


On Tue, Nov 26, 2013 at 5:15 PM, Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote:
>> @@ -36,11 +22,6 @@ static void pci_destroy_dev(struct pci_dev *dev)
>> {
>> device_del(&dev->dev);
>>
>> - down_write(&pci_bus_sem);
>> - list_del(&dev->bus_list);
>> - up_write(&pci_bus_sem);
>> -
>> - pci_free_resources(dev);
>> put_device(&dev->dev);
>
> And if the side effects are benign enough, why don't we do a device_unregister()
> here?

Yes, that is same, but we are using device_add in pci_device_add...

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/