Re: [PATCHv2] perf tools: Fix tags/TAGS targets rebuilding

From: Ingo Molnar
Date: Wed Nov 27 2013 - 06:31:24 EST



* Jiri Olsa <jolsa@xxxxxxxxxx> wrote:

> On Tue, Nov 26, 2013 at 05:13:16PM +0100, Ingo Molnar wrote:
>
> SNIP
>
> > >
> > > #
> > > # Needed if no target specified:
> > > +# (Except for tags and TAGS targets. The reason is that the
> > > +# Makefile does not treat tags/TAGS as targets but as files
> > > +# and thus won't rebuilt them once they are in place.)
> >
> > s/rebuilt/rebuild
> >
> > Btw., could we perhaps change the targets to 'ctags' and 'etags'
> > instead? (That will make it natural to add 'gtags' in the future,
> > should anyone want that.)
>
> my fingers vote against removing 'make tags' (and cscope)
> dont care much about the rest though.. ;-)

Okay, fair enough, and 'tags/TAGS' targets is also what the main
kernel build system uses - so I concur. For your updated v2 patch:

Acked-by: Ingo Molnar <mingo@xxxxxxxxxx>

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/