Re: [PATCH v5 1/2] regulator: max14577: Add regulator driver forMaxim 14577

From: Mark Brown
Date: Wed Nov 27 2013 - 11:29:37 EST


On Wed, Nov 27, 2013 at 04:13:23PM +0000, Lee Jones wrote:
> On Wed, 27 Nov 2013, Mark Brown wrote:

> > The usual thing to do is of_get_child_by_name() on the parent to get the
> > container to search in.

> What do you mean when you say 'usual thing'? Only the max8998 does
> this currently. IMHO the better way to do it for MFD devices is
> provide a compatible string and let the framework does the rest for
> you.

No, as3722, Palmas and three of the TPS chips do the same thing. If it
were a purely Linux-internal thing I'd probably agree with you but as it
is we'd just be adding compatible strings in everyone's DTs to save one
line of code in the kernel.

Attachment: signature.asc
Description: Digital signature