Re: [tip:sched/urgent] sched: Check sched_domain before computinggroup power

From: David Rientjes
Date: Wed Nov 27 2013 - 21:57:59 EST


On Tue, 19 Nov 2013, tip-bot for Srikar Dronamraju wrote:

> Commit-ID: 9abf24d465180f5f2eb26a43545348262f16b771
> Gitweb: http://git.kernel.org/tip/9abf24d465180f5f2eb26a43545348262f16b771
> Author: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx>
> AuthorDate: Tue, 12 Nov 2013 22:11:26 +0530
> Committer: Ingo Molnar <mingo@xxxxxxxxxx>
> CommitDate: Tue, 19 Nov 2013 17:01:15 +0100
>
> sched: Check sched_domain before computing group power
>
> After commit 863bffc80898 ("sched/fair: Fix group power_orig
> computation"), we can dereference rq->sd before it is set.
>
> Fix this by falling back to power_of() in this case and add a comment
> explaining things.
>
> Signed-off-by: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx>
> [ Added comment and tweaked patch. ]
> Signed-off-by: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: mikey@xxxxxxxxxxx
> Link: http://lkml.kernel.org/r/20131113151718.GN21461@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>

Acked-by: David Rientjes <rientjes@xxxxxxxxxx>

Fixes a boot failure for me, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/