Re: [PATCH 02/10] crypto: scatterwalk - Set the chain pointerindication bit

From: Herbert Xu
Date: Thu Nov 28 2013 - 09:21:39 EST


On Tue, Nov 12, 2013 at 11:46:10AM -0600, Tom Lendacky wrote:
> The scatterwalk_crypto_chain function invokes the scatterwalk_sg_chain
> function to chain two scatterlists, but the chain pointer indication
> bit is not set. When the resulting scatterlist is used, for example,
> by sg_nents to count the number of scatterlist entries, a segfault occurs
> because sg_nents does not follow the chain pointer to the chained scatterlist.
>
> Update scatterwalk_sg_chain to set the chain pointer indication bit as is
> done by the sg_chain function.
>
> Signed-off-by: Tom Lendacky <thomas.lendacky@xxxxxxx>

Patch applied. Thanks!

We should also get rid of the crypto-specific SG helpers since
the generic SG helpers are now available everywhere.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/