Re: [PATCH 6/6] kexec: Support for Kexec on panic using new systemcall

[Vivek Goyal]

On Thu, Nov 28, 2013 at 07:28:16PM +0800, Baoquan He wrote:

[..]
> > +int crash_copy_backup_region(struct kimage *image)
> > +{
> 
> Why need this func be called, backup region has been added into crash
> segment by kexec_add_buffer, and then buffer copy is done in
> kimage_load_crash_segment. I think this copy is handled twice. Please
> correct me if I am wrong.
> 

Hi Bao,

kexec_add_buffer() will copy the backup region but it will happen when
crash kernel is loaded. We want snapshot of backup region at the time
of crash and that's why this second call to copy backup region and it
is executed after the crash.

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/