Re: [PATCH 2/3] pinctrl: Add msm8x74 configuration

[Linus Walleij]

On Sun, Nov 24, 2013 at 12:38 AM, Bjorn Andersson
<bjorn.andersson@xxxxxxxxxxxxxx> wrote:

> Add initial definition of parameters for pinctrl-msm for the msm8x74
> platform.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx>

SO mostly this looks just normal, nothing to add here except:

> +static struct pinctrl_gpio_range msm8x74_range = {
> +       .name = "msm8x74",
> +       .npins = NUM_GPIO_PINGROUPS
> +};

This thing may not even be needed when adding the range from the
GPIOchip side of the world.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/