Re: [PATCH v4 1/3] mfd: tps6586x: add version detection

From: Lee Jones
Date: Wed Dec 04 2013 - 03:10:32 EST


> +int tps6586x_get_version(struct device *dev)
> +{
> + struct tps6586x *tps6586x = dev_get_drvdata(dev);
> +
> + return tps6586x->version;
> +}
> +EXPORT_SYMBOL_GPL(tps6586x_get_version);

I thought Mark suggested that this routine was converted to a 'static
inline' and moved into the header? Did you not think this was a good
idea?

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/