Re: [PATCH RFC] mm readahead: Fix the readahead fail in case ofempty numa node

From: Andrew Morton
Date: Wed Dec 04 2013 - 03:40:34 EST


On Wed, 04 Dec 2013 14:00:09 +0530 Raghavendra K T <raghavendra.kt@xxxxxxxxxxxxxxxxxx> wrote:

> > I don't recall the rationale for the current code and of course we
> > didn't document it. It might be in the changelogs somewhere - could
> > you please do the git digging and see if you can find out?
>
> Unfaortunately, from my search, I saw that the code belonged to pre git
> time, so could not get much information on that.

Here: https://lkml.org/lkml/2004/8/20/242

It seems it was done as a rather thoughtless performance optimisation.
I'd say it's time to reimplement max_sane_readahead() from scratch.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/