Re: [PATCH v2] pinctrl: baytrail: lock IRQs when starting them

[Mika Westerberg]

On Tue, Dec 03, 2013 at 06:02:18PM +0200, Mathias Nyman wrote:
> On 12/03/2013 05:00 PM, Linus Walleij wrote:
> >This uses the new API for tagging GPIO lines as in use by
> >IRQs. This enforces a few semantic checks on how the underlying
> >GPIO line is used.
> >
> >Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> >Cc: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> >Cc: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
> >Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> >---
> >ChangeLog v1->v2:
> >- Actually make the change compile, doh.
> >---
> >  drivers/pinctrl/pinctrl-baytrail.c | 22 ++++++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> >
> >diff --git a/drivers/pinctrl/pinctrl-baytrail.c b/drivers/pinctrl/pinctrl-baytrail.c
> >index 1174ea86b6e9..998dbb0c4c93 100644
> >--- a/drivers/pinctrl/pinctrl-baytrail.c
> >+++ b/drivers/pinctrl/pinctrl-baytrail.c
> >@@ -372,11 +372,33 @@ static void byt_irq_mask(struct irq_data *d)
> >  {
> >  }
> >
> >+static unsigned int byt_irq_startup(struct irq_data *d)
> >+{
> >+	struct byt_gpio *vg = irq_data_get_irq_handler_data(d);
> 
> This should probably be:
> 
> struct byt_gpio *vg = irq_data_get_irq_chip_data(d);
> 
> As chip methods use irq_data->chip_data, not irq_data->handler_data
> (Mika tested that it works on baytrail)

Yes, if it uses irq_data_get_irq_handler_data() I get NULL vg pointer and
the kernel crashes. Using irq_data_get_irq_chip_data() makes it work.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/