Re: [PATCH 1/2] usb: chipidea: fix mistake in device tree bindingof nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio'

From: Mark Rutland
Date: Wed Dec 04 2013 - 07:18:57 EST


On Wed, Dec 04, 2013 at 09:20:07AM +0000, dt.tangr@xxxxxxxxx wrote:
> From: Daniel Tang <dt.tangr@xxxxxxxxx>
>
> The SoC name was mistakenly used instead of the vendor name in the
> device tree binding for nspire-usb.
>
> This patch fixes this before the driver becomes widely adopted.

How widely adopted is it so far?

I can't see the binding in mainline yet.

>
> Signed-off-by: Daniel Tang <dt.tangr@xxxxxxxxx>
> ---
> Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt | 4 ++--
> drivers/usb/chipidea/ci_hdrc_nspire.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt
> index 5ba8e90..ef1fcbf 100644
> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt
> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt
> @@ -1,7 +1,7 @@
> * TI-Nspire USB OTG Controller
>
> Required properties:
> -- compatible: Should be "zevio,nspire-usb"
> +- compatible: Should be "lsi,nspire-usb"

Surely this should be lsi,zevio-usb, matching the lsi,zevio-timer
binding?

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/