Re: [PATCH 28/28] perf tools: Add udis86 disassembler feature check

From: Jiri Olsa
Date: Thu Dec 05 2013 - 03:05:44 EST


On Wed, Dec 04, 2013 at 03:50:24PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Dec 03, 2013 at 02:09:42PM +0100, Jiri Olsa escreveu:
> > Adding udis86 disassembler feature check which support
> > is needed for kvm:kvm_emulate_insn tracepoint.
> >
> > +$(call feature_check,udis86)
> > +ifeq ($(feature-udis86), 1)
> > + LIBTRACEEVENT_CFLAGS += -DHAVE_UDIS86
> > + EXTLIBS += -ludis86
> > +else
> > + msg := $(warning No udis86 support.);
> > +endif
>
> That is really an incomplete message, what package should I install?
> Perhaps we should add this there then:
>
> http://bit.ly/1hyrN52

nice :-)

>
> Wow, that was easy, but yeah, could be made easier 8-) ;-P

so something like:
No udis86 found. Please install udis86-devel.

or:
No udis86 found, disabling kvm tracepoints instruction disassembly. Please install udis86-devel.

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/