Re: linux-next: Tree for Dec 3 (mm/Kconfig)

[David Rientjes]

On Thu, 5 Dec 2013, Sima Baymani wrote:

> > CONFIG_HWPOISON_INJECT is unrelated, it already depends on CONFIG_PROC_FS.
> >
> > CONFIG_PROC_PAGE_MONITOR is obviously only useful for CONFIG_PROC_FS, so
> > the correct fix would be to make CONFIG_MEM_SOFT_DIRTY depend on
> > CONFIG_PROC_FS.
> >
> > Want to try sending a patch?
> 
> You bet!
> 
> However, I have the slightest confusion:
> I tested what you suggested by running "make oldconfig", and it does
> eliminate the error. However, I can't figure out why it's enough with
> adding the dependency for PROC_FS in MEM_SOFT_DIRTY, if
> PROC_PAGE_MONITOR depends on both?
> 

"select" will force the option to be selected regardless of its 
dependencies, so in this case you have CONFIG_MEM_SOFT_DIRTY set and
CONFIG_PROC_FS unset and CONFIG_MEM_SOFT_DIRTY enables PROC_PAGE_MONITOR 
which depends on CONFIG_PROC_FS.  The warning you're fixing shows the 
missing dependency.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/