Re: [PATCH 1/1] ramdisk: documentation update

[Fabian Frederick]

On Sat, 07 Dec 2013 19:19:11 -0800
Randy Dunlap wrote:

> On 12/06/13 15:52, Fabian Frederick wrote:
> > -ramdisk_blocksize doesn't exist anymore.
> > -Module parameters added to documentation.
> > 
> > Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>
> > ---
> >  Documentation/blockdev/ramdisk.txt | 23 ++++++++++++++++++-----
> >  1 file changed, 18 insertions(+), 5 deletions(-)
> > 
> > diff --git a/Documentation/blockdev/ramdisk.txt b/Documentation/blockdev/ramdisk.txt
> > index fa72e97..5dca7b1 100644
> > --- a/Documentation/blockdev/ramdisk.txt
> > +++ b/Documentation/blockdev/ramdisk.txt
> > @@ -36,21 +36,30 @@ allowing one to squeeze more programs onto an average installation or
> >  rescue floppy disk.
> >  
> >  
> > -2) Kernel Command Line Parameters
> > +2) Parameters
> >  ---------------------------------
> >  
> > +2a) Kernel Command Line Parameters
> > +
> >  	ramdisk_size=N
> >  	==============
> >  
> >  This parameter tells the RAM disk driver to set up RAM disks of N k size.  The
> >  default is 4096 (4 MB) (8192 (8 MB) on S390).
> 
> I don't find any place that S390 changes CONFIG_BLK_DEV_RAM_SIZE from its default
> of 4096 to 8192.  Did you?  If so, where please?

You're right, it's an old S390 recommendation.I'm removing it as well :)

> 
> 
> >  
> > -	ramdisk_blocksize=N
> > -	===================
> > +2b) Module parameters
> > +
> > +	rd_nr
> > +	=====
> > +	/dev/ramX devices created.
> >  
> > -This parameter tells the RAM disk driver how many bytes to use per block.  The
> > -default is 1024 (BLOCK_SIZE).
> > +	max_part
> > +	========
> > +	Maximum partition number.
> >  
> > +	rd_size
> > +	=======
> > +	cf ramdisk_size.
> 
> Compare to ramdisk_size?  how about
> 
> 	See ramdisk_size.
> or
> 	Same as ramdisk_size.

ok.
> 
> >  
> >  3) Using "rdev -r"
> >  ------------------
> 
> 
> As for the Changelog, it would be better just to delete all of it.
> That's what git is for (and good at).

Git only gives post 2008 updates.I guess we keep previous changelogs in text mode where 
available ?

I had no reaction to this patch (also about ramdisk) 
https://lkml.org/lkml/2013/12/6/748
Should I merge it to this one ?

> 
> 
> -- 
> ~Randy

Fabian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/