Re: [PATCH v3] xen/debugfs: Check debugfs initialization beforeusing it

[Greg KH]

On Mon, Dec 09, 2013 at 05:56:52PM +0800, Ethan Zhao wrote:
> From: "ethan.zhao" <ethan.kernel@xxxxxxxxx>
> 
> Should check debugfs initialization with debugfs_initialized() before using it,
> Because if it isn't initialized, the return value of fake debugfs_create_dir() etc
> functions would be ERR_PTR(-ENODEV), checking with NULL will not work.
> 
> V3: add warning message when debugfs not configured or disabled.

That's not what this patch does...

> Signed-off-by: ethan.zhao <ethan.kernel@xxxxxxxxx>
> ---
>  arch/x86/xen/debugfs.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/x86/xen/debugfs.c b/arch/x86/xen/debugfs.c
> index c8377fb..85c0e0e 100644
> --- a/arch/x86/xen/debugfs.c
> +++ b/arch/x86/xen/debugfs.c
> @@ -9,12 +9,18 @@ static struct dentry *d_xen_debug;
>  
>  struct dentry * __init xen_init_debugfs(void)
>  {
> +	if (!debugfs_initialized()) {
> +		d_xen_debug = NULL;
> +		goto nodebugfs;
> +	}

Again, why is this even needed?

What problem in the existing code are you trying to solve?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/