Re: [PATCH -next] x86, kaslr: remove unused including <linux/version.h>

[Kees Cook]

On Sat, Dec 7, 2013 at 5:02 AM, Wei Yongjun <weiyj.lk@xxxxxxxxx> wrote:
> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
>
> Remove including <linux/version.h> that don't need it.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>

Thanks, yeah, ultimately utsrelease.h had everything that was needed.

Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>

> ---
>  arch/x86/boot/compressed/aslr.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/boot/compressed/aslr.c b/arch/x86/boot/compressed/aslr.c
> index 84be175..90a21f4 100644
> --- a/arch/x86/boot/compressed/aslr.c
> +++ b/arch/x86/boot/compressed/aslr.c
> @@ -10,7 +10,6 @@
>  #include <linux/uts.h>
>  #include <linux/utsname.h>
>  #include <generated/utsrelease.h>
> -#include <linux/version.h>
>
>  /* Simplified build-specific string for starting entropy. */
>  static const char build_str[] = UTS_RELEASE " (" LINUX_COMPILE_BY "@"
>

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/