Re: [PATCHv4] clocksource: dw_apb_timer_of: Fix read_sched_clock

From: Dinh Nguyen
Date: Tue Dec 10 2013 - 10:55:31 EST


On Tue, 2013-12-10 at 16:53 +0100, Ingo Molnar wrote:
> * dinguyen@xxxxxxxxxx <dinguyen@xxxxxxxxxx> wrote:
>
> > From: Dinh Nguyen <dinguyen@xxxxxxxxxx>
> >
> > The read_sched_clock should return the ~value because the clock is a
> > countdown implementation. read_sched_clock() should be the same as
> > __apbt_read_clocksource().
> >
> > Maintain backwards compatibility for "dw-apb-timer-sp" and
> > "dw-apb-timer-osc".
>
> Are these two independent fixes? If yes then they should be in
> separate patches. In general we want to apply minimized, obvious,
> single-purpose fix patches.

Yes, I will split them.

Thanks,
Dinh
>
> Thanks,
>
> Ingo
>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/