Re: [PATCH RESEND 1/2] proc: change return values whileget_proc_task err

From: Andrew Morton
Date: Tue Dec 10 2013 - 18:02:47 EST


On Mon, 9 Dec 2013 20:11:54 +0800 Rui Xiang <rui.xiang@xxxxxxxxxx> wrote:

> While getting proc task error, it shoule return -ESRCH.
>
> ...
>
> --- a/fs/proc/base.c
> +++ b/fs/proc/base.c
> @@ -174,9 +174,10 @@ static int get_task_root(struct task_struct *task, struct path *root)
> static int proc_cwd_link(struct dentry *dentry, struct path *path)
> {
> struct task_struct *task = get_proc_task(dentry->d_inode);
> - int result = -ENOENT;
> + int result = -ESRCH;

I suppose so. But there is risk here of breaking existing applications
and I don't think this problem is serious enough to justify that risk?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/