Re: [PATCH] hfsplus: Remove hfsplus_file_lookup

From: Christoph Hellwig
Date: Thu Dec 12 2013 - 03:19:02 EST


On Thu, Dec 12, 2013 at 10:35:01AM +0400, Vyacheslav Dubeyko wrote:
> I think that I can implement support of resource forks by means of xattr
> way. Also, currently, I am implementing HFS+ compressed files support.
> So, I can clean up old-fashioned way of resource forks support in HFS+
> driver because of necessity to rework it anyway. The suggested patch
> doesn't make all necessary cleanup, from my viewpoint.
>
> Any comments?

The patch is required band aid to fix easily user visible and
triggerable breakage. As such it should go in ASAP and not be blocked
by additional cleanups. That doesn't mean that I wouldn't love to see
your planned rework and additional cleanups later.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/