Re: [PATCH 1/3] wait-simple: Introduce the simple waitqueueimplementation

[Steven Rostedt]

On Thu, 12 Dec 2013 16:25:42 +0100 (CET)
Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:

> On Thu, 12 Dec 2013, Steven Rostedt wrote:
> > On Thu, 12 Dec 2013 09:48:06 -0500
> > Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> wrote:
> >  
> > > 1) git mv wait.[ch] --- > cwait.[ch]
> > >    make an empty wait.h include cwait.h temporarily
> > > 
> > > 2) rename all existing functions in cwait.[ch] to have an added
> > >   "c" prefix (or similar)
> > >    
> > >    in wait.h, temporarily add a bunch of things like
> > >           #define wait_xyz  cwait_xyz
> > >    so that things still compile and link.
> > 
> > What about instead change all users of wait_*() to cwait_*().
> > 
> > Then the next steps would be to skip 3 and jump right to 4)
> > 
> > > 
> > > 3) track down the users who really need the extra complexity
> > >    and have them use cwait calls and include cwait.h
> > > 
> > > 4) bring in the simple wait queue support as wait.c and wait.h
> > >    and delete the defines added in step two.  This will be the
> > >    flag day commit.
> > 
> > Not a flag day commit, as no one is using it. Then start converting all
> > users back to the wait_*() functions one at a time. If something
> > breaks, we know which one it was.
> 
> I don't think its a good idea to flip the name spaces.
> 
> We should rather convert the existing stuff over to cwait or whatever
> and keep the swait for the new facility. So it breaks everything which
> is trying to use wait*
> 
>        - out of tree code
>        - students copying from ldd3
>        - ...
>        [ not that I care much about any of that ]
> 
> in a very obvious way.
> 

That still happens in my approach too, in the same step. When the
simple wait queue is added, everything will break that uses it when it
should not have. That includes, out of tree code, students copying
from ldd3, etc.

And it too will break in a very obvious way.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/