Re: [PATCH] Driver core: Fix device_add_attrs() error code path

From: Rafael J. Wysocki
Date: Thu Dec 12 2013 - 23:47:24 EST


On Thursday, December 12, 2013 03:13:33 PM Greg Kroah-Hartman wrote:
> On Thu, Dec 12, 2013 at 06:11:02AM +0100, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> >
> > If the addition of dev_attr_online fails, device_add_attrs() should
> > remove device attribute groups as well as type and class attribute
> > groups before returning an error code. Make that happen.
> >
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> Does this need tob e in 3.13-final? Or can it wait for 3.14-rc1? The
> odds that this file creation would ever fail is _really_ low, right?

Yeah, it's more of a cleanup than a fix, so 3.14-rc1 should be fine.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/