Re: [PATCH v6 6/7] arm64, jump label: optimize jump labelimplementation

From: Will Deacon
Date: Fri Dec 13 2013 - 10:55:56 EST


On Fri, Dec 13, 2013 at 03:50:23PM +0000, Steven Rostedt wrote:
> On Fri, 13 Dec 2013 15:41:04 +0000
> Will Deacon <will.deacon@xxxxxxx> wrote:
>
> > > +#include <linux/kernel.h>
> > > +#include <linux/jump_label.h>
> > > +#include <asm/jump_label.h>
> > > +#include <asm/insn.h>
> > > +
> > > +#ifdef HAVE_JUMP_LABEL
> >
> > Slightly worrying... this should be CONFIG_HAVE_JUMP_LABEL, right? How did
> > you manage to test this code?
>
> In <linux/jump_label.h> we have:
>
> #if defined(CC_HAVE_ASM_GOTO) && defined(CONFIG_JUMP_LABEL)
>
> [...]
>
> # include <asm/jump_label.h>
> # define HAVE_JUMP_LABEL
> #endif /* CC_HAVE_ASM_GOTO && CONFIG_JUMP_LABEL */
>

Phew, that explains things! Cheers, Steve.

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/