Re: [PATCH 1/5] xfs: factor prid related codes intoxfs_get_initial_prid()

From: Christoph Hellwig
Date: Fri Dec 13 2013 - 11:32:21 EST


> +static inline prid_t xfs_get_initial_prid(struct xfs_inode *dp)
> +{
> + if (dp->i_d.di_flags & XFS_DIFLAG_PROJINHERIT)
> + return xfs_get_projid(dp);
> + else
> + return XFS_PROJID_DEFAULT;
> +}

You could skip the else here.

Otherwise looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/