Re: [PATCH 3/3] drivers: edac: Mark the functionget_mci_for_node_id() as static in sb_edac.c

From: Josh Triplett
Date: Sat Dec 14 2013 - 15:29:10 EST


On Sat, Dec 14, 2013 at 07:32:09PM +0530, Rashika Kheria wrote:
> This patch marks the function get_mci_for_node_id() as static in
> sb_edac.c because it is not used outside this file.
>
> Thus, it also eliminates the following warning in sb_edac.c:
> drivers/edac/sb_edac.c:918:22: warning: no previous prototype for âget_mci_for_node_idâ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx>

Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>

> drivers/edac/sb_edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
> index 8472405..a8845a3 100644
> --- a/drivers/edac/sb_edac.c
> +++ b/drivers/edac/sb_edac.c
> @@ -915,7 +915,7 @@ static void get_memory_layout(const struct mem_ctl_info *mci)
> }
> }
>
> -struct mem_ctl_info *get_mci_for_node_id(u8 node_id)
> +static struct mem_ctl_info *get_mci_for_node_id(u8 node_id)
> {
> struct sbridge_dev *sbridge_dev;
>
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/