Re: [PATCH v7] gpio: davinci: use {readl|writel}_relaxed() insteadof __raw_*

From: Sekhar Nori
Date: Sun Dec 15 2013 - 06:37:01 EST


On Friday 13 December 2013 09:34 AM, Prabhakar Lad wrote:
> Hi Linus,
>
> On Fri, Dec 13, 2013 at 2:01 AM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>> On Wed, Dec 11, 2013 at 6:52 PM, Prabhakar Lad
>> <prabhakar.csengg@xxxxxxxxx> wrote:
>>
>>> From: "Lad, Prabhakar" <prabhakar.csengg@xxxxxxxxx>
>>>
>>> This patch replaces the __raw_readl/writel with
>>> {readl|writel}_relaxed(), Altough the code runs on ARMv5
>>> based SOCs, changing this will help copying the code

s/copying/using

>>> for other uses.

Call out usability on big-endian machines specifically here.

>>>
>>> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>
>>> ---
>>> This patch is part of series [1] rest of the patches
>>> are Acked/reviewed so posting this patch independently
>>> and marking it as v7.
>>>
>>> [1] http://www.spinics.net/lists/devicetree/msg13037.html
>>>
>>> drivers/gpio/gpio-davinci.c | 36 ++++++++++++++++++------------------
>>
>> Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>>
> Thanks for the Ack.
>
>> Should I take this into the GPIO tree, or should it go
>> in through the DaVinci tree?
>>
> To avoid dependencies its better it goes via DaVinci tree.

I added this to v3.14/gpio branch of my tree (with modifications I
mentioned above).

I dont think there are dependencies for this particular patch though
(applies and builds nicely on latest Linus T's tree). Even then, there
are too many GPIO patches floating around and I think it is better for
me to collect them for a while and if there really are no platform code
dependencies overall, I can probably hand that branch off to Linus W. We
will see.

Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/