Re: [PATCH 3/3] pci: Add Virtual Channel to save/restore support

From: Alex Williamson
Date: Tue Dec 17 2013 - 15:29:06 EST


On Tue, 2013-12-17 at 11:03 -0700, Bjorn Helgaas wrote:
> On Tue, Dec 10, 2013 at 11:48:45AM -0700, Alex Williamson wrote:
> >...
> > + pci_read_config_dword(dev->bus->self, pos2 + PCI_VC_PORT_REG1, &reg1);
> > + evcc = reg1 & PCI_VC_REG1_EVCC;
>
> I think PCI_VC_PORT_REG1 and PCI_VC_PORT_REG2 are mis-named and should be
> changed to CAP1 and CAP2 or similar. Almost everything here is a
> "register."

That's true, but it matches the name in the spec: "Port VC Capability
Register 1/2". Thanks,

Alex

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/