Re: [PATCH v4 0/2] mfd: rtsx: decrease driver size and add new device

From: Dan Carpenter
Date: Wed Dec 18 2013 - 01:57:27 EST


On Wed, Dec 18, 2013 at 10:03:11AM +0800, micky_ching@xxxxxxxxxxxxxx wrote:
> From: Micky Ching <micky_ching@xxxxxxxxxxxxxx>
>
> we add a macro to simplify setting pull control, and use a common init
> function to init the common params for 8411-like chips. at last we add
> support for rtl8402 chip.
>
> Micky Ching (2):
> mfd: rtsx: add set pull control macro and simplify rtl8411
> mfd: rtsx: add support for card reader rtl8402
>
> drivers/mfd/rtl8411.c | 95 ++++++++++++++++++++++++++----------------------
> drivers/mfd/rtsx_pcr.c | 5 +++
> drivers/mfd/rtsx_pcr.h | 9 +++++
> 3 files changed, 66 insertions(+), 43 deletions(-)
>

Great. Looks good to me.

Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/