RE: [PATCH v3 2/8] drivers: net: Mark functions as static inqlcnic_83xx_hw.c

From: Shahed Shaikh
Date: Thu Dec 19 2013 - 06:51:24 EST


> -----Original Message-----
> From: Rashika Kheria [mailto:rashika.kheria@xxxxxxxxx]
> Sent: Thursday, December 19, 2013 2:18 PM
> To: linux-kernel; Himanshu Madhani; Rajesh Borundia; Shahed Shaikh;
> Jitendra Kalsaria; Sony Chacko; Sucheta Chakraborty; Dept-Eng Linux Driver;
> netdev; josh@xxxxxxxxxxxxxxxx
> Subject: [PATCH v3 2/8] drivers: net: Mark functions as static in
> qlcnic_83xx_hw.c
>
> This patch marks the function qlcnic_83xx_clear_legacy_intr_mask(),
> qlcnic_83xx_set_legacy_intr_mask() and
> qlcnic_83xx_enable_legacy_msix_mbx_intr() in qlcnic_83xx_hw.c as static
> because they are not used outside this file.
>
> Thus, it also removes the following warnings in
> ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:
>
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:318:13: warning: no
> previous prototype for âqlcnic_83xx_clear_legacy_intr_maskâ [-Wmissing-
> prototypes]
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:323:13: warning: no
> previous prototype for âqlcnic_83xx_set_legacy_intr_maskâ [-Wmissing-
> prototypes]
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:343:13: warning: no
> previous prototype for âqlcnic_83xx_enable_legacy_msix_mbx_intrâ [-
> Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx>
> Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>

Acked-by: Shahed Shaikh <shahed.shaikh@xxxxxxxxxx>

Thanks,
Shahed
N‹§²æìr¸›yúèšØb²X¬¶ÇvØ^–)Þ{.nÇ+‰·¥Š{±‘êçzX§¶›¡Ü}©ž²ÆzÚ&j:+v‰¨¾«‘êçzZ+€Ê+zf£¢·hšˆ§~†­†Ûiÿûàz¹®w¥¢¸?™¨è­Ú&¢)ßf”ù^jÇy§m…á@A«a¶Úÿ 0¶ìh®å’i