Re: [PATCH] usb/gadget: should use u16 type variable to storeMaxPower

From: Felipe Balbi
Date: Thu Dec 19 2013 - 09:49:37 EST


On Tue, Dec 17, 2013 at 11:47:42AM +0000, Du, ChangbinX wrote:
> From 7e827a0d300e084f74c65122baa5e3193f9a7f18 Mon Sep 17 00:00:00 2001
> From: "Du, Changbin" <changbinx.du@xxxxxxxxx>
> Date: Mon, 16 Dec 2013 20:32:13 +0800
> Subject: [PATCH] usb/gadget: should use u16 type variable to store MaxPower
>
> The MaxPower field is of u16 type. So using u8 type variable can break

Alright I see we need some cleanups around that area in the gadget
framework.

Descriptor is always a u8, no question about it. But
usb_gadget_vbus_draw() receives a u32 as argument, while
struct usb_configuration defines it as u16.

I'll take this patch anyway, as it solves a real issue. Thanks

--
balbi

Attachment: signature.asc
Description: Digital signature