Re: [PATCH] mm,numa,THP: initialize hstate for THP page size

From: Rik van Riel
Date: Thu Dec 19 2013 - 10:18:46 EST


On 12/19/2013 05:22 AM, Michal Hocko wrote:
> [Adding Dave and Mel]

> copy_huge_page as hugetlb specific thing. It relies on hstate which is
> obviously not existing for THP pages. So why do we use it for thp pages
> in the first place?
>
> Mel, your "mm: numa: Add THP migration for the NUMA working set scanning
> fault case." has added check for PageTransHuge in migrate_page_copy so
> it uses the shared copy_huge_page now. Dave has already tried to fix it
> by https://lkml.org/lkml/2013/10/28/592 but this one has been dropped
> later with "to-be-updated".
>
> Dave do you have an alternative for your patch?

Gah, never mind me. This oops happened on a slightly older tree,
that did not have Dave's patch yet...

Andrew, you can drop the patch. Sorry for the noise.

--
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/