Re: [PATCH v2] net: mvmdio: fix interrupt timeout handling

From: David Miller
Date: Thu Dec 19 2013 - 19:21:43 EST


From: Leigh Brown <leigh@xxxxxxxxxxxxx>
Date: Thu, 19 Dec 2013 13:09:48 +0000

> This version corrects the whitespace issue.
>
> orion_mdio_wait_ready uses wait_event_timeout to wait for the
> SMI interrupt to fire. wait_event_timeout waits for between
> "timeout - 1" and "timeout" jiffies. In this case a 1ms timeout
> when HZ is 1000 results in a wait of 0 to 1 jiffies, causing
> premature timeouts.
>
> This fix ensures a minimum timeout of 2 jiffies, ensuring
> wait_event_timeout will always wait at least 1 jiffie.
>
> Issue reported by Nicolas Schichan.
>
> Tested-by: Nicolas Schichan <nschichan@xxxxxxxxxx>
> Signed-off-by: Leigh Brown <leigh@xxxxxxxxxxxxx>

Applied, and queued up for -stable.

I wonder how many other wait_event_timeout() users potentially have
this problem.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/