Re: [PATCH] pid: change task_struct::pid to read-only

From: Richard Guy Briggs
Date: Thu Dec 19 2013 - 23:48:58 EST


On 13/12/17, Peter Zijlstra wrote:
> On Mon, Dec 16, 2013 at 04:03:38PM -0500, Richard Guy Briggs wrote:
> > task->pid is only ever assigned once (well ok, twice). For system health and
> > secure logging confidence, make it const to make it much more intentional when
> > it is being changed.
> > ---
> >
> > Peter, as you had suggested, does this approach work for you in terms of making
> > task_struct::pid a lot more difficult to accidentally change to try to preserve
> > its integrity?
>
> Yeah, looks good to me.

Ok, who would carry this patch? You? AKPM? Me?

Any opinions about Oleg's macro idea?

- RGB

--
Richard Guy Briggs <rbriggs@xxxxxxxxxx>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/