Re: [PATCH 3/4] block: null_blk: fix queue leak inside removingdevice

From: Christoph Hellwig
Date: Mon Dec 23 2013 - 11:26:54 EST


On Tue, Dec 24, 2013 at 12:18:58AM +0800, Ming Lei wrote:
> del_gendisk(nullb->disk);
> - if (queue_mode == NULL_Q_MQ)
> - blk_mq_free_queue(nullb->q);
> - else
> - blk_cleanup_queue(nullb->q);
> + blk_cleanup_queue(nullb->q);

All exported users of blk_mq_free_queue go away with this change, so
make sure it's not available anymore. I have to say the one in
blk-sysfs.c also looks suspicious.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/