RE: [PATCH v4 1/3] regulator: act8865: add PMIC act8865 driver

From: Yang, Wenyou
Date: Mon Dec 23 2013 - 21:14:45 EST




> -----Original Message-----
> From: Mark Brown [mailto:broonie@xxxxxxxxxx]
> Sent: Monday, December 23, 2013 7:58 PM
> To: Yang, Wenyou
> Cc: lgirdwood@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> grant.likely@xxxxxxxxxx; rob.herring@xxxxxxxxxxx; linux-
> doc@xxxxxxxxxxxxxxx; vpalatin@xxxxxxxxxxxx; Ferre, Nicolas;
> plagnioj@xxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v4 1/3] regulator: act8865: add PMIC act8865 driver
>
> On Mon, Dec 23, 2013 at 01:25:28PM +0800, Wenyou Yang wrote:
>
> > +static int act8865_set_suspend_voltage(struct regulator_dev *rdev,
> > +int uV) {
> > + u32 selector;
> > +
> > + selector = regulator_map_voltage_iterate(rdev, uV, uV);
> > +
> > + return regulator_set_voltage_sel_regmap(rdev, selector); }
>
> This looks wrong - it's going to set the normal voltage register that is
> set for runtime voltage changes. The suspend operations are only for
> setting separate voltage registers, many PMICs know about system suspend
> and provide separate settings for that. If this one doesn't then it
> shouldn't implement this operation.
I re-read the act8865 datasheet, There is NO a separate voltage registers for the suspend operation.
So I will remove this operation.

Thanks.

Best Regards,
Wenyou Yang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/