Re: [PATCH -tip 1/3] [CLEANUP] perf-probe: Expand given path to absolutepath
From: Masami Hiramatsu
Date: Tue Dec 24 2013 - 01:51:46 EST
(2013/12/23 23:28), Arnaldo Carvalho de Melo wrote:
> Em Mon, Dec 23, 2013 at 06:35:09AM +0900, Masami Hiramatsu escreveu:
>> (2013/12/21 3:00), Arnaldo Carvalho de Melo wrote:
>>> Em Fri, Dec 20, 2013 at 10:02:57AM +0000, Masami Hiramatsu escreveu:
>>>> Expand given path to absolute path in option parser,
>>>> except for a module name. Instead of expanding it later,
>>>> this get the absolute path in early stage.
>>> What is the problem this solves?
>>> Can you provide some output showing the problem, i.e. before you apply
>>> this patch?
>> No, this is just a code cleanup, for the later enhancements.
> Ok, this is just a cleanup, but what does this cleanup achieves? Why is
> it better to "getting the absolute path in early stage"?
> I.e. you're describing what the patch does, and I can see it from
> reading code, but why is it good to do it in an early stage?
Since realpath at the later stage in processing several probe point
can be called several times(even if currently doesn't, it can happen
when we expands the feature), it is waste of the performance.
Processing it once at the early stage can avoid that.
Is that good enough for you? :)
>> Should I put it into the next patch?
> No need for that, just, please, clarify why it is needed.
OK, I'll do that:)
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/