Re: [PATCH v5 1/3] regulator: act8865: add PMIC act8865 driver

From: Mark Brown
Date: Tue Dec 24 2013 - 08:52:03 EST

On Tue, Dec 24, 2013 at 10:34:28AM +0800, Wenyou Yang wrote:
> Signed-off-by: Wenyou Yang <wenyou.yang@xxxxxxxxx>

I've applied this, however there is one small issue which I seem to have
forgotten to point out previously:

> + /* Finally register devices */
> + for (i = 0; i < pdata->num_regulators; i++) {

The driver should register all regulators regardless of how many are
used in the system in order to aid diagnostics. Please send an
incremental patch to fix this.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at