Re: [PATCH v2 06/20] ppp: slight optimization of addr compare

From: Sergei Shtylyov
Date: Tue Dec 24 2013 - 11:25:04 EST


On 24-12-2013 15:28, Ding Tianhong wrote:

Use possibly more efficient ether_addr_equal
to instead of memcmp.

Cc: Michal Ostrowski <mostrows@xxxxxxxxxxxxx>
Cc: netdev@xxxxxxxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
Signed-off-by: Ding Tianhong <dingtianhong@xxxxxxxxxx>
drivers/net/ppp/pppoe.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
index 82ee6ed..1808a10 100644
--- a/drivers/net/ppp/pppoe.c
+++ b/drivers/net/ppp/pppoe.c
@@ -131,12 +131,13 @@ static inline struct pppoe_net *pppoe_pernet(struct net *net)

static inline int cmp_2_addr(struct pppoe_addr *a, struct pppoe_addr *b)
- return a->sid == b->sid && !memcmp(a->remote, b->remote, ETH_ALEN);
+ return a->sid == b->sid && ether_addr_equal(a->remote,
+ b->remote);

If it really doesn't fit insto single line, the continuation line should start right under 'a->remote'.

WBR, Sergei

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at