Re: [PATCH stable 1/2] virtio_net: fix error handling for mergeable buffers

From: Michael Dalton
Date: Wed Dec 25 2013 - 13:34:37 EST

Hi Michael, quick question below:

On Wed, Dec 25, 2013 at 6:56 AM, Michael S. Tsirkin <mst@xxxxxxxxxx> wrote:
> if (i >= MAX_SKB_FRAGS) {
> pr_debug("%s: packet too long\n", skb->dev->name);
> skb->dev->stats.rx_length_errors++;
> - return -EINVAL;
> + return NULL;
> }

Should this error handling path free the SKB before returning NULL?
It seems like if we just return NULL we may leak memory.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at